Same audit as the orchestrator standardization pass (2a062e5), extended to
every remaining script. Found the same class of bug independently recurring:
ramdisk_stop.sh checked $LOG (nothing assigns it, should be $ENABLE_LOGGING),
partnership_onboard.sh checked $LOG_MODE (same issue), emby_session_report.sh
checked $TRANSCODE_PCT which was never computed so the high-transcode alert
could never fire, and storage_migrate.sh never called detect_hosts() so
$MY_ID was empty, silently breaking the post-migration host*.conf update.
partnership_manager.sh used `local` at top-level script scope (invalid outside
a function) and had two master.conf path references missing "Configurations/".
Along the way: several scripts (share_setup.sh, conf_sync.sh,
downloaders_reset.sh, transcode_cleanup.sh, transcode_manager.sh,
remote_arr_cache_writer.sh, upgrade_webhook_handler.sh) had no explicit
trailing exit code, so they always reported success regardless of real
failures. play_state_sync.sh was missing the partnership gate its own header
documented, so remote play-state sync ran even with PARTNERSHIP_ENABLED=false;
it also always exited 0 on sync errors. arr_profile_enforcer.sh and
webhook_setup.sh hand-rolled their own flag parsing instead of common.sh's
parse_args, so --log silently did nothing on either.
system_watchdog.sh was itself an un-standardized mini-orchestrator — converted
to the shared run_orch_child()/JOB_PASS/JOB_FAIL pattern, added the missing
failure notification, and fixed dry-run to pass --dry-run down to children
instead of skipping them outright. Also fixed a stale webgui_watchdog.sh path
in master.conf.template that would break system_watchdog.sh on any fresh
install.
Closed a sibling-drift gap: radarr_cleanup.sh and sonarr_cleanup.sh were
missing lidarr_cleanup.sh's tracked-count percentage-drop safety gate and its
"not configured on this host, skip cleanly" guard — both now match Lidarr's
7-gate model.
168 lines
6.5 KiB
Bash
Executable File
168 lines
6.5 KiB
Bash
Executable File
#!/bin/bash
|
|
# ==============================================================================================
|
|
# ============================= Remote Arr Cache Writer ========================================
|
|
# ==============================================================================================
|
|
#
|
|
# PURPOSE
|
|
# ─────────────────────────────────────────────────────────────────────────────
|
|
# SSHes to each remote partner host, calls vv_arrs_local_node() on their PHP
|
|
# stack, and caches the result locally in /tmp/vv_cache/arrs_remote_hostN.json.
|
|
#
|
|
# The arrs page reads these files for instant initial load without hitting the
|
|
# remote arr APIs on every page view. This script runs every 2 hours so remote
|
|
# library counts stay reasonably current without hammering the network.
|
|
#
|
|
# Accepts --host=HOST2 to refresh a single host (used by the UI refresh button).
|
|
#
|
|
# ==============================================================================================
|
|
# DESIGN PRINCIPLES
|
|
# ==============================================================================================
|
|
#
|
|
# Cache-First, Never Live on Page Load
|
|
# Remote arr APIs have non-trivial latency — calling them on every page view
|
|
# would make the arrs page slow and fragile. Writing to /tmp/vv_cache/ on a
|
|
# 2-hour schedule decouples page load time from network availability.
|
|
#
|
|
# Single-Host Refresh for UI
|
|
# The UI refresh button passes --host=HOSTN to update one host without waiting
|
|
# for the full 2-hour cycle. Keeps the cache fresh when a user requests it.
|
|
#
|
|
# ==============================================================================================
|
|
# OPERATIONAL SAFEGUARDS
|
|
# ==============================================================================================
|
|
#
|
|
# acquire_lock — prevents concurrent cache write runs
|
|
# detect_hosts() — MY_ID and partner host list
|
|
# SSH reachability — skips a host cleanly if it cannot be reached
|
|
# /tmp/vv_cache/ — auto-created if missing; cleared on reboot (intentional)
|
|
#
|
|
# ==============================================================================================
|
|
# RUNTIME MODES
|
|
# ==============================================================================================
|
|
#
|
|
# remote_arr_cache_writer.sh — refresh all remote hosts
|
|
# remote_arr_cache_writer.sh --host=HOST2 — refresh one host only
|
|
# remote_arr_cache_writer.sh --dry-run — show what would happen
|
|
# remote_arr_cache_writer.sh --log — verbose output
|
|
#
|
|
# ==============================================================================================
|
|
|
|
SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
|
|
source "$SCRIPT_DIR/../../../load_config.sh"
|
|
|
|
parse_args "$@"
|
|
acquire_lock
|
|
detect_hosts
|
|
|
|
# Parse --host= from raw args
|
|
TARGET_HOST=""
|
|
for arg in "$@"; do
|
|
case "$arg" in --host=*) TARGET_HOST="${arg#--host=}" ;; esac
|
|
done
|
|
|
|
mkdir -p "$VV_CACHE_DIR"
|
|
|
|
log "$ICON_GEAR Config: target=${TARGET_HOST:-all hosts} ssh-key=${SSH_KEY}"
|
|
|
|
FETCH_OK=0
|
|
FETCH_FAIL=0
|
|
FETCH_SKIP=0
|
|
|
|
echo ""
|
|
echo "━━━ $ICON_SYNC Remote Arr Cache Writer ━━━"
|
|
[[ "$DRY_RUN" == true ]] && warn "DRY RUN — no changes will be made"
|
|
[[ -n "$TARGET_HOST" ]] && echo " Target: $TARGET_HOST"
|
|
echo ""
|
|
|
|
for host_var in HOST1 HOST2 HOST3 HOST4 HOST5 HOST6 HOST7 HOST8; do
|
|
[[ "$host_var" == "$MY_ID" ]] && continue
|
|
|
|
hostname="${!host_var:-}"
|
|
[[ -z "$hostname" ]] && continue
|
|
|
|
# If targeting a specific host, skip others
|
|
if [[ -n "$TARGET_HOST" ]]; then
|
|
[[ "${host_var,,}" != "${TARGET_HOST,,}" && "$host_var" != "$TARGET_HOST" ]] && continue
|
|
fi
|
|
|
|
host_id="${host_var,,}" # host1, host2, …
|
|
cache_file="$VV_CACHE_DIR/arrs_remote_${host_id}.json"
|
|
|
|
echo " $host_var ($hostname)…"
|
|
|
|
if [[ "$DRY_RUN" == true ]]; then
|
|
warn " DRY RUN — would SSH to $hostname and cache arr data"
|
|
(( FETCH_SKIP++ ))
|
|
continue
|
|
fi
|
|
|
|
# Resolve Tailscale IP
|
|
REMOTE_IP=$(resolve_tailscale_ip "$hostname")
|
|
if [[ -z "$REMOTE_IP" ]]; then
|
|
warn " $host_var: cannot resolve Tailscale IP for $hostname — skipping"
|
|
(( FETCH_FAIL++ ))
|
|
continue
|
|
fi
|
|
log " $host_var: resolved $hostname → $REMOTE_IP"
|
|
|
|
# Single SSH connection — fetch arrs + monitor stats together
|
|
RESULT=$(ssh -i "$SSH_KEY" \
|
|
-o ConnectTimeout=10 \
|
|
-o StrictHostKeyChecking=no \
|
|
-o BatchMode=yes \
|
|
"root@${REMOTE_IP}" \
|
|
"php -r \"
|
|
require_once '/usr/local/emhttp/plugins/varaverk/include/arrs.php';
|
|
require_once '/usr/local/emhttp/plugins/varaverk/include/unraid_api.php';
|
|
echo json_encode([
|
|
'arrs' => vv_arrs_local_node(),
|
|
'monitor' => vv_local_host_stats(),
|
|
]);
|
|
\"" 2>/dev/null)
|
|
|
|
if [[ -z "$RESULT" ]]; then
|
|
warn " $host_var: empty SSH response — skipping"
|
|
(( FETCH_FAIL++ ))
|
|
continue
|
|
fi
|
|
|
|
# Validate combined JSON
|
|
if ! echo "$RESULT" | php -r "
|
|
\$d = json_decode(file_get_contents('php://stdin'), true);
|
|
exit(!is_array(\$d) || !isset(\$d['arrs'], \$d['monitor']) ? 1 : 0);
|
|
" 2>/dev/null; then
|
|
warn " $host_var: invalid JSON — skipping"
|
|
log " Response: ${RESULT:0:200}"
|
|
(( FETCH_FAIL++ ))
|
|
continue
|
|
fi
|
|
|
|
# Save arr cache
|
|
echo "$RESULT" | php -r "
|
|
\$d = json_decode(file_get_contents('php://stdin'), true);
|
|
file_put_contents('$cache_file', json_encode(\$d['arrs']));
|
|
" 2>/dev/null
|
|
|
|
# Save monitor cache
|
|
MONITOR_CACHE="$VV_CACHE_DIR/monitor_remote_${host_id}.json"
|
|
echo "$RESULT" | php -r "
|
|
\$d = json_decode(file_get_contents('php://stdin'), true);
|
|
file_put_contents('$MONITOR_CACHE', json_encode(\$d['monitor']));
|
|
" 2>/dev/null
|
|
|
|
CACHED_TYPES=$(echo "$RESULT" | php -r "
|
|
\$d = json_decode(file_get_contents('php://stdin'), true);
|
|
echo implode(', ', array_column(\$d['arrs']['arrs'] ?? [], 'type'));
|
|
" 2>/dev/null)
|
|
echo " $host_var: arrs [${CACHED_TYPES:-none}] + monitor stats cached ✅"
|
|
(( FETCH_OK++ ))
|
|
done
|
|
|
|
echo ""
|
|
echo "━━━━━ $ICON_SUMMARY Cache Writer Summary ━━━━━"
|
|
echo " $FETCH_OK updated · $FETCH_FAIL failed · $FETCH_SKIP skipped"
|
|
echo "━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━"
|
|
|
|
[[ "$FETCH_FAIL" -gt 0 ]] && exit 1
|
|
exit 0
|