Let a non-blocking checklist item be dismissed with a recorded decision, and run discovery on the mirror once there is something to discover

2026-08-16 21:56:00 -04:00
parent 39dba3f8ab
commit cce1e25c2b
5 changed files with 146 additions and 6 deletions
@@ -226,10 +226,14 @@ function vv_setup_state_read(): array {
 }

 // Write the setup state file (creates or overwrites).
-function vv_setup_state_write(array $data): void {
+// Returns whether the write landed. Was void, so a caller had no way to tell a full flash or a
+// read-only mount from success — and `if (!vv_setup_state_write(...))` on a void function is
+// always true, which turns "it worked" into a reported failure. Existing void callers are
+// unaffected by the added return.
+function vv_setup_state_write(array $data): bool {
    $content = '';
    foreach ($data as $k => $v) $content .= "$k=$v\n";
-    file_put_contents(VV_SETUP_STATE_FILE, $content);
+    return file_put_contents(VV_SETUP_STATE_FILE, $content) !== false;
 }

 // Push the setup state file to all remote hosts via scp.