From c7e81edf4dec4d4e00a96ffa8c7700dd2373f659 Mon Sep 17 00:00:00 2001
From: Gmer4Lfe <gmer4lfe@gmail.com>
Date: Sat, 30 May 2026 18:24:41 -0400
Subject: [PATCH] Partnership: move action fns to top-level scope, remove
 window. approach
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

window.fn = inside an IIFE is not reliable in all script-loading contexts.
Move vvPtPhase1/2, vvPtOnboard, vvPtOffboard and their _vvPtRun helper
above the IIFE as plain top-level function declarations — unconditionally
global and reachable from onclick= attributes.
---
 Plugin/unraid/pages/partnership.php | 104 ++++++++++++++--------------
 1 file changed, 52 insertions(+), 52 deletions(-)

diff --git a/Plugin/unraid/pages/partnership.php b/Plugin/unraid/pages/partnership.php
index 79d1c1f..177463a 100644
--- a/Plugin/unraid/pages/partnership.php
+++ b/Plugin/unraid/pages/partnership.php
@@ -56,6 +56,58 @@
 </div>
 
 <script>
+// ── Public action functions — defined at top level so onclick= can reach them ──
+function _vvPtRun(id, extraArgs) {
+  const params = {id, manual: '1'};
+  if (extraArgs) params.extra_args = extraArgs;
+  return fetch('/plugins/varaverk/api/run.php', {
+    method: 'POST',
+    body: new URLSearchParams(params)
+  }).then(r => r.json());
+}
+
+function vvPtPhase1(btn, hostId) {
+  if (!confirm(`Phase 1: SSH key exchange + conf push to ${hostId}?\n\nSafe to run before ${hostId} has Varaverk installed.`)) return;
+  btn.disabled = true;
+  btn.textContent = '⟳ Starting…';
+  _vvPtRun('Partnership/partnership_onboard.sh', '--phase1-only')
+    .then(d => { if (!d.ok) alert('Failed: ' + (d.error ?? 'Unknown error')); })
+    .catch(e => alert('Error: ' + e))
+    .finally(() => setTimeout(() => { btn.disabled = false; btn.textContent = '▶ Phase 1: SSH + Conf Push'; }, 3000));
+}
+
+function vvPtPhase2(btn, hostId) {
+  if (!confirm(`Phase 2: Deploy containers + arr stack + establish partnership on ${hostId}?\n\nRequires ${hostId} to have Varaverk installed and SSH keys set up.`)) return;
+  btn.disabled = true;
+  btn.textContent = '⟳ Starting…';
+  _vvPtRun('Partnership/partnership_onboard.sh', '--phase2-only')
+    .then(d => { if (!d.ok) alert('Failed: ' + (d.error ?? 'Unknown error')); })
+    .catch(e => alert('Error: ' + e))
+    .finally(() => setTimeout(() => { btn.disabled = false; btn.textContent = '▶ Run Phase 2 Manually'; }, 3000));
+}
+
+function vvPtOnboard(btn) {
+  if (!confirm('Run full partnership_onboard.sh?\n\nRun on the MIRROR first, then on the OWNER.\n\nUse Phase 1 + Phase 2 buttons for step-by-step control.')) return;
+  btn.disabled = true;
+  btn.textContent = '⟳ Starting…';
+  _vvPtRun('Partnership/partnership_onboard.sh')
+    .then(d => { if (!d.ok) alert('Failed: ' + (d.error ?? 'Unknown error')); })
+    .catch(e => alert('Error: ' + e))
+    .finally(() => setTimeout(() => { btn.disabled = false; btn.textContent = '▶ Onboard (Mirror)'; }, 4000));
+}
+
+function vvPtOffboard(btn) {
+  if (btn.style.opacity === '0.35' || btn.style.cursor === 'default') return;
+  if (!confirm('Run partnership_offboard.sh?\n\nThis will end the partnership, reconfigure WebUIs, and revoke SSH access.\n\nContinue?')) return;
+  btn.disabled = true;
+  btn.textContent = '⟳ Starting…';
+  _vvPtRun('Partnership/partnership_offboard.sh')
+    .then(d => { if (!d.ok) alert('Failed: ' + (d.error ?? 'Unknown error')); })
+    .catch(e => alert('Error: ' + e))
+    .finally(() => setTimeout(() => { btn.disabled = false; btn.textContent = '▶ Offboard'; }, 4000));
+}
+
+// ── Private page logic ─────────────────────────────────────────────────────────
 (function() {
 
 // ── Helpers ───────────────────────────────────────────────────────────────────
@@ -340,58 +392,6 @@ function _render(data) {
   document.getElementById('vv-pt-ts').textContent = ts ? 'Updated: ' + ts : '';
 }
 
-// ── Actions ───────────────────────────────────────────────────────────────────
-
-function _vvPtRun(id, extraArgs) {
-  const params = {id, manual: '1'};
-  if (extraArgs) params.extra_args = extraArgs;
-  return fetch('/plugins/varaverk/api/run.php', {
-    method: 'POST',
-    body: new URLSearchParams(params)
-  }).then(r => r.json());
-}
-
-window.vvPtPhase1 = function(btn, hostId) {
-  if (!confirm(`Phase 1: SSH key exchange + conf push to ${hostId}?\n\nSafe to run before ${hostId} has Varaverk installed.`)) return;
-  btn.disabled = true;
-  btn.textContent = '⟳ Starting…';
-  _vvPtRun('Partnership/partnership_onboard.sh', '--phase1-only')
-    .then(d => { if (!d.ok) alert('Failed: ' + (d.error ?? 'Unknown error')); })
-    .catch(e => alert('Error: ' + e))
-    .finally(() => setTimeout(() => { btn.disabled = false; btn.textContent = '▶ Phase 1: SSH + Conf Push'; }, 3000));
-};
-
-window.vvPtPhase2 = function(btn, hostId) {
-  if (!confirm(`Phase 2: Deploy containers + arr stack + establish partnership on ${hostId}?\n\nRequires ${hostId} to have Varaverk installed and SSH keys set up.`)) return;
-  btn.disabled = true;
-  btn.textContent = '⟳ Starting…';
-  _vvPtRun('Partnership/partnership_onboard.sh', '--phase2-only')
-    .then(d => { if (!d.ok) alert('Failed: ' + (d.error ?? 'Unknown error')); })
-    .catch(e => alert('Error: ' + e))
-    .finally(() => setTimeout(() => { btn.disabled = false; btn.textContent = '▶ Run Phase 2 Manually'; }, 3000));
-};
-
-window.vvPtOnboard = function(btn) {
-  if (!confirm('Run full partnership_onboard.sh?\n\nRun on the MIRROR first, then on the OWNER.\n\nUse Phase 1 + Phase 2 buttons for step-by-step control.')) return;
-  btn.disabled = true;
-  btn.textContent = '⟳ Starting…';
-  _vvPtRun('Partnership/partnership_onboard.sh')
-    .then(d => { if (!d.ok) alert('Failed: ' + (d.error ?? 'Unknown error')); })
-    .catch(e => alert('Error: ' + e))
-    .finally(() => setTimeout(() => { btn.disabled = false; btn.textContent = '▶ Onboard (Mirror)'; }, 4000));
-};
-
-window.vvPtOffboard = function(btn) {
-  if (btn.style.opacity === '0.35' || btn.style.cursor === 'default') return;
-  if (!confirm('Run partnership_offboard.sh?\n\nThis will end the partnership, reconfigure WebUIs, and revoke SSH access.\n\nContinue?')) return;
-  btn.disabled = true;
-  btn.textContent = '⟳ Starting…';
-  _vvPtRun('Partnership/partnership_offboard.sh')
-    .then(d => { if (!d.ok) alert('Failed: ' + (d.error ?? 'Unknown error')); })
-    .catch(e => alert('Error: ' + e))
-    .finally(() => setTimeout(() => { btn.disabled = false; btn.textContent = '▶ Offboard'; }, 4000));
-};
-
 // ── Poll ──────────────────────────────────────────────────────────────────────
 
 function vvPtLoad() {