FailedProxy/Varaverk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix external-link warning on tab navigation

Browse Source 
Tab links use relative query-string hrefs (?tab=scheduler), which fail
every check in Unraid's global external-link click-guard (BodyInlineJS.php):
not a valid absolute URL, doesn't start with "/", doesn't match a
registered plugin page basename. Confirmed live — the guard's dom.hostname
ends up undefined for these, matching the reported "Always Allow undefined"
dialog text exactly.

Fix: add class="localURL", the same escape hatch dynamix's own pages
(ManagementAccess.page) use for this exact situation. Applied to the main
tab bar and the setup wizard's checklist action links (?tab=partnership).
This commit is contained in:
Gmer4Lfe
2026-07-04 23:05:47 -04:00
parent 7e4db7b504
commit a6fe820a61
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Plugin/unraid/Varaverk.page
+1 -1
View File
@@ -36,7 +36,7 @@ $tabLabels = ['monitor' => 'Monitor', 'scheduler' => 'Scheduler', 'docker' => 'D
<!-- Tab bar --> <!-- Tab bar -->
<div id="vv-tabs"> <div id="vv-tabs">
<?php foreach ($validTabs as $t): ?> <?php foreach ($validTabs as $t): ?>
<a href="?tab=<?=$t?>" class="vv-tab<?= $t === $tab ? ' active' : '' ?>"> <a href="?tab=<?=$t?>" class="localURL vv-tab<?= $t === $tab ? ' active' : '' ?>">
<?= $tabLabels[$t] ?? ucfirst($t) ?> <?= $tabLabels[$t] ?? ucfirst($t) ?>
</a> </a>
<?php endforeach; ?> <?php endforeach; ?>
Plugin/unraid/pages/setup.php
+1 -1
View File
@@ -312,7 +312,7 @@ function vvLoadChecklist() {
const lbl = vvActionLabels[item.action] || item.action; const lbl = vvActionLabels[item.action] || item.action;
const href = vvActionHref[item.action]; const href = vvActionHref[item.action];
if (href) { if (href) {
act = `<div class="vv-cl-act"><a href="${href}" style="font-size:11px;color:#556;">${lbl}</a></div>`; act = `<div class="vv-cl-act"><a href="${href}" class="localURL" style="font-size:11px;color:#556;">${lbl}</a></div>`;
} else if (item.action === 'create_key') { } else if (item.action === 'create_key') {
act = `<div class="vv-cl-act"><button onclick="vvCreateKey(this)">${lbl}</button></div>`; act = `<div class="vv-cl-act"><button onclick="vvCreateKey(this)">${lbl}</button></div>`;
} else if (item.action === 'run_populate') { } else if (item.action === 'run_populate') {