FailedProxy/Varaverk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Take the literal script tag out of the comment that broke every tab

Browse Source 
Written with real angle brackets inside the inline block, it ended that element early, so the
file rendered as visible text and no page JS ran at all.
This commit is contained in:
Gmer4Lfe
2026-08-07 10:29:13 -04:00
parent ab794db0ab
commit 9e3755f9ca
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Plugin/unraid/Varaverk.page
+7 -1
View File
@@ -65,10 +65,16 @@ require_once "$pluginDir/include/config.php";
// available to it at all. // available to it at all.
// //
// Not in js/varaverk.js, which would otherwise be the obvious home: that file is loaded by a // Not in js/varaverk.js, which would otherwise be the obvious home: that file is loaded by a
// <script src> *below* the tab include, so it is not defined yet while a page's inline script is // src-tag *below* the tab include, so it is not defined yet while a page's inline script is
// running. The shared formatters there survive only because every caller is inside a fetch // running. The shared formatters there survive only because every caller is inside a fetch
// callback. An escaping helper must be callable from the first synchronous line of a page. // callback. An escaping helper must be callable from the first synchronous line of a page.
// //
// Never write a literal script tag inside this block, not even in a comment. The tab body is
// injected into the page by the webGUI rather than parsed as part of the document, and the
// opening sequence ends this element early wherever it appears — the whole file then renders as
// visible text and every tab loads dead. That is not theoretical: the comment above said it with
// real angle brackets and took the monitor tab down on 2026-08-07.
//
// String() rather than assuming a string: these are fed payload fields that are frequently // String() rather than assuming a string: these are fed payload fields that are frequently
// numbers, and sometimes null or undefined. A helper that throws on a number is a helper call // numbers, and sometimes null or undefined. A helper that throws on a number is a helper call
// sites will skip. // sites will skip.