Fix dead/incorrect vars and consolidate duplicated logic into common.sh

Codebase-wide audit pass: fixed real bugs (SSH hangs missing BatchMode,
local-outside-function no-ops, variable name collisions, a truncated
ratio calc, wrong state-dir path, DARK vs NO_INTERNET drift, and more),
then pulled logic that was duplicated across multiple scripts — arr
cleanup safety gates, docker restart ordering, container maintenance
stop/restart, watchdog state-file helpers, partnership role resolution,
cert expiry checks, remote node discovery, and TMDB discovery scoring —
into common.sh so each now has a single implementation.

Tools/emby_database_repair.sh

@@ -171,16 +171,7 @@ EMBY_WAS_RUNNING=false
 
 cleanup_on_exit() {
     local exit_code=$?
-    if [[ "$EMBY_WAS_RUNNING" == true && "$DRY_RUN" == false ]]; then
-        local status
-        status=$(timeout "$DOCKER_TIMEOUT" docker inspect -f '{{.State.Running}}' \
-            "$EMBY_CONTAINER" 2>/dev/null)
-        if [[ "$status" != "true" ]]; then
-            warn "Restarting $EMBY_CONTAINER (cleanup)..."
-            timeout "$DOCKER_TIMEOUT" docker start "$EMBY_CONTAINER" >/dev/null 2>&1 || \
-                error "Failed to restart $EMBY_CONTAINER — start it manually"
-        fi
-    fi
+    container_force_restart_if_needed "$EMBY_CONTAINER" "$EMBY_WAS_RUNNING"
 }
 
 trap cleanup_on_exit EXIT
@@ -191,36 +182,10 @@ trap cleanup_on_exit EXIT
 echo ""
 echo "━━━ $ICON_STOP Stop Emby ━━━"
 
-STATUS=$(timeout "$DOCKER_TIMEOUT" docker inspect -f '{{.State.Running}}' \
-    "$EMBY_CONTAINER" 2>/dev/null)
-
-case "$STATUS" in
-    true)
-        EMBY_WAS_RUNNING=true
-        warn "Stopping $EMBY_CONTAINER — active sessions will be interrupted"
-        if [[ "$DRY_RUN" == false ]]; then
-            if timeout "$DOCKER_TIMEOUT" docker stop "$EMBY_CONTAINER" >/dev/null 2>&1; then
-                echo "$EMBY_CONTAINER stopped ✅"
-                sleep 3  # let file handles release
-            else
-                error "Failed to stop $EMBY_CONTAINER — aborting"
-                exit 1
-            fi
-        else
-            warn "DRY RUN — would stop $EMBY_CONTAINER"
-        fi
-        ;;
-    false)
-        log "$EMBY_CONTAINER is not running — proceeding with checks"
-        ;;
-    "")
-        error "$EMBY_CONTAINER not found — check container name"
-        exit 1
-        ;;
-    *)
-        warn "$EMBY_CONTAINER status: $STATUS — proceeding with caution"
-        ;;
-esac
+container_stop_for_maintenance "$EMBY_CONTAINER" EMBY_WAS_RUNNING \
+    "Stopping $EMBY_CONTAINER — active sessions will be interrupted" warn 3 || exit 1
+[[ "$EMBY_WAS_RUNNING" == false ]] && \
+    log "$EMBY_CONTAINER is not running — proceeding with checks"
 
 # ==============================================================================================
 # ━━━ Database Integrity Check ━━━
@@ -301,37 +266,8 @@ END=$(date +%s)
 echo ""
 echo "━━━ $ICON_START Restart Emby ━━━"
 
-RESTART_OK=false
-
-if [[ "$EMBY_WAS_RUNNING" == true ]]; then
-    if [[ "$DRY_RUN" == false ]]; then
-        log "Restarting $EMBY_CONTAINER..."
-        if timeout "$DOCKER_TIMEOUT" docker start "$EMBY_CONTAINER" >/dev/null 2>&1; then
-            sleep 5  # Emby takes longer to initialise than most containers
-            POST_STATUS=$(timeout "$DOCKER_TIMEOUT" docker inspect -f \
-                '{{.State.Running}}' "$EMBY_CONTAINER" 2>/dev/null)
-            if [[ "$POST_STATUS" == "true" ]]; then
-                echo "$EMBY_CONTAINER restarted and running ✅"
-                RESTART_OK=true
-            else
-                error "$EMBY_CONTAINER started but crashed — database may be corrupt"
-                error "Check Docker logs: docker logs $EMBY_CONTAINER"
-                notify "$EMBY_CONTAINER crashed on restart — possible database corruption on $(hostname)" \
-                    "Emby DB Repair" "warning"
-            fi
-        else
-            error "Failed to restart $EMBY_CONTAINER — start it manually"
-            notify "$EMBY_CONTAINER failed to restart after integrity check on $(hostname)" \
-                "Emby DB Repair" "warning"
-        fi
-    else
-        warn "DRY RUN — would restart $EMBY_CONTAINER"
-        RESTART_OK=true
-    fi
-else
-    echo "$EMBY_CONTAINER was not running — leaving stopped (state respected) ✅"
-    RESTART_OK=true
-fi
+container_restart_after_maintenance "$EMBY_CONTAINER" "$EMBY_WAS_RUNNING" 5 "Emby DB Repair"
+[[ "$RESTART_OK" == false ]] && error "Check Docker logs: docker logs $EMBY_CONTAINER"
 
 # Clear EXIT trap — clean exit
 trap - EXIT