Fix dead/incorrect vars and consolidate duplicated logic into common.sh

Codebase-wide audit pass: fixed real bugs (SSH hangs missing BatchMode,
local-outside-function no-ops, variable name collisions, a truncated
ratio calc, wrong state-dir path, DARK vs NO_INTERNET drift, and more),
then pulled logic that was duplicated across multiple scripts — arr
cleanup safety gates, docker restart ordering, container maintenance
stop/restart, watchdog state-file helpers, partnership role resolution,
cert expiry checks, remote node discovery, and TMDB discovery scoring —
into common.sh so each now has a single implementation.

Orchestrators/transcode_management.sh

@@ -88,8 +88,9 @@
 # ==============================================================================================
 
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+ECOSYSTEM_ROOT="$(cd "$SCRIPT_DIR/.." && pwd)"
 
-source "$SCRIPT_DIR/../load_config.sh"
+source "$ECOSYSTEM_ROOT/load_config.sh"
 
 parse_args "$@"
 
@@ -158,17 +159,6 @@ if [[ "$SHOW_STATUS" == true ]]; then
     exit 0
 fi
 
-# ==============================================================================================
-# ━━━ Validate Child Scripts ━━━
-# ==============================================================================================
-for _entry in "${TRANSCODE_MANAGEMENT_SCRIPTS[@]}"; do
-    _script_path="$SCRIPT_DIR/../$_entry"
-    if [[ ! -f "$_script_path" ]]; then
-        error "$(basename "$_entry") not found: $_script_path"
-        exit 1
-    fi
-done
-
 # ==============================================================================================
 # ━━━ Pre-run State Snapshot ━━━
 # ==============================================================================================
@@ -188,36 +178,22 @@ fi
 # ==============================================================================================
 # transcode_manager.sh writes to TRANSCODE_DAILY_LOG after each run — no flag here
 # suppresses that; it owns the log write for this cycle regardless of position ✅
-DRY_FLAG=""
-[[ "$DRY_RUN" == true ]] && DRY_FLAG="--dry-run"
-
-WORST_EXIT=0
-PASS_COUNT=0
-FAIL_NAMES=()
+JOB_PASS=()
+JOB_FAIL=()
 for _entry in "${TRANSCODE_MANAGEMENT_SCRIPTS[@]}"; do
-    _script_path="$SCRIPT_DIR/../$_entry"
-    _script_name=$(basename "$_entry" .sh)
-    _start=$(date +%s)
-    bash "$_script_path" $DRY_FLAG
-    _exit=$?
-    log "$_script_name: $(format_duration $(( $(date +%s) - _start ))) (exit $_exit)"
-    if [[ "$_exit" -ne 0 ]]; then
-        WORST_EXIT=1
-        FAIL_NAMES+=("$_script_name")
-    else
-        PASS_COUNT=$(( PASS_COUNT + 1 ))
-    fi
+    [[ -z "$_entry" ]] && continue
+    run_orch_child "$_entry"
 done
 
 # ==============================================================================================
 # ━━━ Summary — minimal one-liner by default (7-min cadence — keep it quiet when healthy) ━━━
 # ==============================================================================================
-if [[ "$WORST_EXIT" -eq 0 ]]; then
-    echo "$ICON_SUCCESS Transcode cycle — $PASS_COUNT/${#TRANSCODE_MANAGEMENT_SCRIPTS[@]} passed"
+if [[ "${#JOB_FAIL[@]}" -eq 0 ]]; then
+    echo "$ICON_SUCCESS Transcode cycle — ${#JOB_PASS[@]}/${#TRANSCODE_MANAGEMENT_SCRIPTS[@]} passed"
 else
-    error "Transcode cycle — failed: ${FAIL_NAMES[*]}"
+    error "Transcode cycle — failed: ${JOB_FAIL[*]}"
     if [[ "$DRY_RUN" != true ]]; then
-        notify "Transcode management failure on $(hostname) ($MY_ID) — ${FAIL_NAMES[*]}" \
+        notify "Transcode management failure on $(hostname) ($MY_ID) — ${JOB_FAIL[*]}" \
             "Transcode Management" "warning"
     fi
 fi
@@ -225,5 +201,5 @@ fi
 # ==============================================================================================
 # ━━━ Exit ━━━
 # ==============================================================================================
-# Return worst exit code — caller knows if any script failed
-exit "$WORST_EXIT"
+[[ "${#JOB_FAIL[@]}" -gt 0 ]] && exit 1
+exit 0