Fix dead/incorrect vars and consolidate duplicated logic into common.sh

Codebase-wide audit pass: fixed real bugs (SSH hangs missing BatchMode,
local-outside-function no-ops, variable name collisions, a truncated
ratio calc, wrong state-dir path, DARK vs NO_INTERNET drift, and more),
then pulled logic that was duplicated across multiple scripts — arr
cleanup safety gates, docker restart ordering, container maintenance
stop/restart, watchdog state-file helpers, partnership role resolution,
cert expiry checks, remote node discovery, and TMDB discovery scoring —
into common.sh so each now has a single implementation.

Docker_Essentials/docker_weekly_restart.sh

@@ -158,58 +158,7 @@ fi
 
 # docker_cmd, retry_docker, verify_running — defined in common.sh
 
-# Builds a dependency-safe restart order from WEEKLY_RESTART_CONTAINERS.
-# Containers that are dependencies of others restart first.
-build_restart_order() {
-    ORDERED_RESTART=()
-    local remaining=("${WEEKLY_RESTART_CONTAINERS[@]}")
-    local placed=()
-
-    # First pass — add dependency containers that appear in our list
-    for container in "${remaining[@]}"; do
-        [[ -z "$container" ]] && continue
-        local is_dependency=false
-        for dependent in "${!WATCHDOG_DEPENDENCIES[@]}"; do
-            if [[ "${WATCHDOG_DEPENDENCIES[$dependent]}" == *"$container"* ]]; then
-                is_dependency=true
-                break
-            fi
-        done
-        if [[ "$is_dependency" == true ]]; then
-            local already=false
-            for p in "${placed[@]}"; do [[ "$p" == "$container" ]] && already=true && break; done
-            if [[ "$already" == false ]]; then
-                ORDERED_RESTART+=("$container")
-                placed+=("$container")
-            fi
-        fi
-    done
-
-    # Second pass — add remaining containers (dependents and independents)
-    for container in "${remaining[@]}"; do
-        [[ -z "$container" ]] && continue
-        local already=false
-        for p in "${placed[@]}"; do [[ "$p" == "$container" ]] && already=true && break; done
-        if [[ "$already" == false ]]; then
-            ORDERED_RESTART+=("$container")
-            placed+=("$container")
-        fi
-    done
-
-    log "Restart order: ${ORDERED_RESTART[*]}"
-}
-
-# Waits CONTAINER_DELAY if this container depends on the last restarted one.
-check_dependency_delay() {
-    local container="$1"
-    local last="$2"
-    [[ -z "$last" ]] && return
-    local deps="${WATCHDOG_DEPENDENCIES[$container]:-}"
-    if [[ -n "$deps" ]] && [[ "$deps" == *"$last"* ]]; then
-        log "Waiting ${CONTAINER_DELAY}s — $container depends on $last..."
-        sleep "$CONTAINER_DELAY"
-    fi
-}
+# build_restart_order() / check_dependency_delay() — provided by common.sh
 
 # ==============================================================================================
 # ━━━ Weekly Restart ━━━
@@ -226,15 +175,13 @@ RESTARTED=()
 SKIPPED=()
 
 # Build dependency-safe restart order
-build_restart_order
+build_restart_order WEEKLY_RESTART_CONTAINERS
 
 LAST_RESTARTED=""
 
 for container in "${ORDERED_RESTART[@]}"; do
     [[ -z "$container" ]] && continue
-    local c_start
     c_start=$(date +%s)
-    local c_image
     c_image=$(docker inspect --format '{{.Config.Image}}' "$container" 2>/dev/null || echo "unknown")
     log "━━━ $ICON_CONTAINERS $container ($c_image) ━━━"