Fix dead/incorrect vars and consolidate duplicated logic into common.sh

Codebase-wide audit pass: fixed real bugs (SSH hangs missing BatchMode,
local-outside-function no-ops, variable name collisions, a truncated
ratio calc, wrong state-dir path, DARK vs NO_INTERNET drift, and more),
then pulled logic that was duplicated across multiple scripts — arr
cleanup safety gates, docker restart ordering, container maintenance
stop/restart, watchdog state-file helpers, partnership role resolution,
cert expiry checks, remote node discovery, and TMDB discovery scoring —
into common.sh so each now has a single implementation.

Docker_Essentials/docker_daily_restart.sh

@@ -159,71 +159,7 @@ fi
 
 # docker_cmd, verify_running, retry_docker — defined in common.sh
 
-# Builds a dependency-safe restart order from DAILY_RESTART_CONTAINERS.
-# Containers that are dependencies of others restart first.
-# Returns ordered list in ORDERED_RESTART array.
-build_restart_order() {
-    ORDERED_RESTART=()
-    local remaining=("${DAILY_RESTART_CONTAINERS[@]}")
-    local placed=()
-
-    # First pass — add dependency containers that appear in our list
-    for container in "${remaining[@]}"; do
-        [[ -z "$container" ]] && continue
-        local is_dependency=false
-        # Check if this container is a dependency of any other in our list
-        for dep_string in "${WATCHDOG_DEPENDENCIES[@]}"; do
-            if [[ "$dep_string" == *"$container"* ]]; then
-                is_dependency=true
-                break
-            fi
-        done
-        # Also check associative array format
-        for dependent in "${!WATCHDOG_DEPENDENCIES[@]}"; do
-            if [[ "${WATCHDOG_DEPENDENCIES[$dependent]}" == *"$container"* ]]; then
-                is_dependency=true
-                break
-            fi
-        done
-        if [[ "$is_dependency" == true ]]; then
-            # Check not already placed
-            local already=false
-            for p in "${placed[@]}"; do [[ "$p" == "$container" ]] && already=true && break; done
-            if [[ "$already" == false ]]; then
-                ORDERED_RESTART+=("$container")
-                placed+=("$container")
-            fi
-        fi
-    done
-
-    # Second pass — add remaining containers (dependents and independents)
-    for container in "${remaining[@]}"; do
-        [[ -z "$container" ]] && continue
-        local already=false
-        for p in "${placed[@]}"; do [[ "$p" == "$container" ]] && already=true && break; done
-        if [[ "$already" == false ]]; then
-            ORDERED_RESTART+=("$container")
-            placed+=("$container")
-        fi
-    done
-
-}
-
-# Checks if a container is a dependent of the previously restarted container.
-# If so, waits CONTAINER_DELAY before restarting to allow dependency to settle.
-# Usage: check_dependency_delay "$container" "$last_restarted"
-check_dependency_delay() {
-    local container="$1"
-    local last="$2"
-    [[ -z "$last" ]] && return
-
-    local deps="${WATCHDOG_DEPENDENCIES[$container]:-}"
-    if [[ -n "$deps" ]] && [[ "$deps" == *"$last"* ]]; then
-        echo "  Waiting ${CONTAINER_DELAY}s — $container depends on $last..."
-        sleep "$CONTAINER_DELAY"
-    fi
-}
-
+# build_restart_order() / check_dependency_delay() — provided by common.sh
 
 # ==============================================================================================
 # ━━━ Daily Restart ━━━
@@ -241,8 +177,7 @@ RESTARTED=()
 SKIPPED=()
 
 # Build dependency-safe restart order
-build_restart_order
-log "$ICON_GEAR Restart order: ${ORDERED_RESTART[*]}"
+build_restart_order DAILY_RESTART_CONTAINERS
 
 LAST_RESTARTED=""