Enhanced log. fixed some general inconsistencies

Orchestrators/daily_sync.sh

@@ -14,6 +14,19 @@ source "$SCRIPT_DIR/../common.sh"
  
 RSYNC_SCRIPT="$SCRIPT_DIR/../Rsync/rsync.sh"
  
+# -----------------------------------------------------------------------------------------------
+# --- $ICON_GEAR Setup ---
+# -----------------------------------------------------------------------------------------------
+echo ""
+echo "--- $ICON_GEAR Setup ---"
+ 
+detect_hosts
+resolve_remote_ip
+ 
+# Single connectivity check upfront — fail fast before attempting all shares
+# against an unreachable host rather than failing per-share through the loop
+check_connectivity
+ 
 # -----------------------------------------------------------------------------------------------
 # Tracking
 # -----------------------------------------------------------------------------------------------
@@ -21,22 +34,24 @@ PASS=()
 FAIL=()
 SHARE_TIMES=()
 TOTAL_START=$(date +%s)
+SHARE_COUNT=${#DAILY_SYNC_SHARES[@]}
  
 # -----------------------------------------------------------------------------------------------
-# Run
+# --- $ICON_SYNC Transfer ---
 # -----------------------------------------------------------------------------------------------
 echo ""
-echo "$ICON_SYNC Daily Sync Starting — $(date '+%Y-%m-%d %H:%M:%S')"
-echo "Shares: ${#DAILY_SYNC_SHARES[@]}"
+echo "--- $ICON_SYNC Daily Sync Starting — $(date '+%Y-%m-%d %H:%M:%S') ---"
+echo "Shares: $SHARE_COUNT"
 echo ""
  
+SHARE_INDEX=0
+ 
 for SHARE in "${DAILY_SYNC_SHARES[@]}"; do
+    SHARE_INDEX=$((SHARE_INDEX + 1))
     SHARE_NAME=$(basename "$SHARE")
     SHARE_START=$(date +%s)
  
-    echo "----------------------------------------"
-    info "Syncing $SHARE_NAME..."
-    echo "----------------------------------------"
+    echo "--- $ICON_SYNC Share $SHARE_INDEX of $SHARE_COUNT: $SHARE_NAME ---"
  
     if bash "$RSYNC_SCRIPT" "$SHARE"; then
         SHARE_END=$(date +%s)
@@ -56,7 +71,7 @@ TOTAL_END=$(date +%s)
 TOTAL_DURATION=$((TOTAL_END - TOTAL_START))
  
 # -----------------------------------------------------------------------------------------------
-# Summary
+# --- $ICON_SUCCESS Summary ---
 # -----------------------------------------------------------------------------------------------
 echo "===== DAILY SYNC SUMMARY ====="
 echo "Started:  $(date -d @$TOTAL_START '+%Y-%m-%d %H:%M:%S')"
@@ -72,8 +87,8 @@ for entry in "${SHARE_TIMES[@]}"; do
     fi
 done
 echo ""
-echo "  Passed:   ${#PASS[@]}/${#DAILY_SYNC_SHARES[@]}"
-echo "  Failed:   ${#FAIL[@]}/${#DAILY_SYNC_SHARES[@]}"
+echo "  Passed:   ${#PASS[@]}/$SHARE_COUNT"
+echo "  Failed:   ${#FAIL[@]}/$SHARE_COUNT"
 echo "  Duration: $(format_duration $TOTAL_DURATION)"
 echo "=============================="