Disarm on offboard every sync gate onboard arms, with the same helper, so the two are one operation in both directions

2026-08-16 21:36:46 -04:00
parent 3ae6298656
commit 27989d066e
4 changed files with 103 additions and 46 deletions
@@ -885,7 +885,10 @@ do_final_sync() {
            warn "CRITICAL_SYNC_SHARES is empty — skipping final sync (configure in host*.conf)"
        fi
    else
-        warn "DRY RUN — would run final critical sync (${#CRITICAL_SYNC_SHARES[@]:-hardcoded} shares)"
+        # ${#ARR[@]} and :- cannot be combined — bash rejects the whole word as "bad substitution",
+        # so this line aborted Step 2 of every offboard --dry-run with a shell error instead of
+        # printing. A count of an unset array is already 0, which is the only default needed.
+        warn "DRY RUN — would run final critical sync (${#CRITICAL_SYNC_SHARES[@]} shares)"
    fi
    warn "Final sync complete — mirror has current state ✅"
 }